Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(druid): No transform without time granularity for consistency #17146

Merged
merged 1 commit into from
Oct 18, 2021
Merged

chore(druid): No transform without time granularity for consistency #17146

merged 1 commit into from
Oct 18, 2021

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Oct 18, 2021 •
edited
Loading

SUMMARY

Apologies @ktmud per the Presto spec, for simplicity, if no granularity is specified then no transformation should occur. See #17101 for details.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley requested review from ktmud and etr2460 October 18, 2021 17:14
@john-bodley john-bodley changed the title fix(druid): Time granularity chore(druid): No transform without time granularity for consistency Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #17146 (31b6489) into master (565ee23) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17146      +/-   ##
==========================================
+ Coverage   76.67%   76.68%   +0.01%     
==========================================
  Files        1038     1038              
  Lines       55516    55542      +26     
  Branches     7564     7564              
==========================================
+ Hits        42567    42594      +27     
+ Misses      12699    12698       -1     
  Partials      250      250
Flag Coverage Δ
javascript 70.92% <ø> (+0.02%) ⬆️
mysql 81.90% <ø> (ø)
postgres 81.91% <ø> (+0.01%) ⬆️
python 81.99% <ø> (+0.01%) ⬆️
sqlite 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/druid.py 86.27% <ø> (ø)
...src/dashboard/components/DashboardBuilder/state.ts 71.42% <0.00%> (-1.75%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 80.64% <0.00%> (-0.47%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 88.09% <0.00%> (-0.10%) ⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx 100.00% <0.00%> (ø)
.../FilterBar/CascadeFilters/CascadePopover/index.tsx 63.23% <0.00%> (ø)
...frontend/src/components/TimezoneSelector/index.tsx 97.77% <0.00%> (+0.05%) ⬆️
...src/filters/components/Range/RangeFilterPlugin.tsx 88.57% <0.00%> (+0.33%) ⬆️
superset/reports/commands/execute.py 91.22% <0.00%> (+0.38%) ⬆️
...ilters/FilterBar/FilterControls/FilterControls.tsx 80.85% <0.00%> (+0.85%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 565ee23...31b6489. Read the comment docs.

@john-bodley john-bodley merged commit d38e686 into master Oct 18, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@john-bodley
Update druid.py (apache#17146)
aac1282
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the john-bodley--druid-time-grain-expression branch March 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

@ktmud ktmud Awaiting requested review from ktmud

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @etr2460 @mistercrunch